AIMP Forum

AIMP for PC => Ошибки и замечания / Bugs => Обработано / Processed => Topic started by: sveakul on June 14, 2024, 00:07:03

Title: [x] [2555] [x64] changed album art download behavior with streams
Post by: sveakul on June 14, 2024, 00:07:03
In prefs I have Album Arts checked to "Find on Internet", no save, no cache.  I am listening to Internet radio streams.

ln 2549 and earlier this always produced the behavior of AIMP doing an Internet search for the cover and displaying the results from one of the sources in aimp_webLyrics.ini if found.  If the cover was not found, BUT the station itself was providing a "default/genre" cover (as is the case with SomaFM and also Radio Caprice), AIMP would display that cover.

In 2555, the behavior has changed so that if the stream itself is providing a "default/genre" cover, that cover receives display priority and no Internet search is performed from the aimp_webLyrics.ini file for a cover specific to that track.

Not sure if this was a deliberate change or a bug, but could this be changed back to the original behavior?  When a track/artist specific album cover can be found on the Internet for the streaming song, THAT is the cover I want to see, not one of the canned SomaFM or Radio Caprice "category covers."
Title: Re: [2555] [x64] changed album art download behavior with streams
Post by: Artem on June 14, 2024, 08:54:23
Soolo, не, есть косяк. Он проявляется только в том случае, если станция передает обложку в поле URL. В текущей сборке URL имеет приоритет перед поиском в сети. Я пока не знаю, как это фиксить
Title: Re: [2555] [x64] changed album art download behavior with streams
Post by: Soolo on June 14, 2024, 09:01:54
Soolo, не, есть косяк. Он проявляется только в том случае, если станция передает обложку в поле URL. В текущей сборке URL имеет приоритет перед поиском в сети. Я пока не знаю, как это фиксить
Да, верно, я допустил типовую ошибку, не обновился =)
Title: Re: [2555] [x64] changed album art download behavior with streams
Post by: Artem on June 14, 2024, 09:13:38
In prefs I have Album Arts checked to "Find on Internet", no save, no cache.  I am listening to Internet radio streams.

ln 2549 and earlier this always produced the behavior of AIMP doing an Internet search for the cover and displaying the results from one of the sources in aimp_webLyrics.ini if found.  If the cover was not found, BUT the station itself was providing a "default/genre" cover (as is the case with SomaFM and also Radio Caprice), AIMP would display that cover.

In 2555, the behavior has changed so that if the stream itself is providing a "default/genre" cover, that cover receives display priority and no Internet search is performed from the aimp_webLyrics.ini file for a cover specific to that track.

Not sure if this was a deliberate change or a bug, but could this be changed back to the original behavior?  When a track/artist specific album cover can be found on the Internet for the streaming song, THAT is the cover I want to see, not one of the canned SomaFM or Radio Caprice "category covers."

The URL-based provider has been moved from the Internet to File Tags category, it was necessary during fix another bug. As I see now, the provider should be out of both of them to operate correctly in both cases. I need some time to find best solution for both cases
Title: Re: [2555] [x64] changed album art download behavior with streams
Post by: sveakul on June 14, 2024, 11:28:39
The URL-based provider has been moved from the Internet to File Tags category, it was necessary during fix another bug. As I see now, the provider should be out of both of them to operate correctly in both cases. I need some time to find best solution for both cases
Thank you Artem for recognizing this as a real problem.  I'm not sure what what fix would be "broken" by simply reverting back to the original behavior??  In File Tags people have always been free to select cover art for a file using a variety of methods.  In radio streams, the only way we could reliably enjoy the track art was by the weblyrics plugin's wonderful Internet searching ability.

While I realize this change has only affected streams that DO send "default/stub" images, it's my misfortune that this includes the stations I listen to most, SomaFM and Radio Caprice.  I've reverted back to 2549 for that reason, and am hoping you can find a fix.  Thank you for listening to my concern, I hope I'm not the only user who this matters to.
Title: Re: [2555] [x64] changed album art download behavior with streams
Post by: Artem on June 14, 2024, 14:14:08
Please, try this build:
https://disk.yandex.ru/d/kLSPw-GPCEwbyw
Title: Re: [2555] [x64] changed album art download behavior with streams
Post by: sveakul on June 15, 2024, 03:21:48
Please, try this build:
https://disk.yandex.ru/d/kLSPw-GPCEwbyw
AH, what a relief!  Completely fixed, tested both the SomaFM and Radio Caprice playlists.  Real HQ covers again.  Thanks Artem for the fast fix!  I used the build to update directly over the existing Portable one.
Title: Re: [x] [2555] [x64] changed album art download behavior with streams
Post by: Artem on June 15, 2024, 06:44:39
Thanks for testing